[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: easy but may be suboptimal fixes for recent kmail crashes
From:       Till Adam <till () adam-lilienthal ! de>
Date:       2003-07-01 14:56:11
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 30 June 2003 19:39, Carsten Burghardt wrote:
> On Monday 30 June 2003 18:58, Christophe Prud'homme wrote:
> > Hello
> > I experience since yesterday(with the freshest CVS actually) crashes in
> > kmail I looked a bit and I made the following two changes below
> > that solve my problems
> > it seems that some msg can be 0 sometimes
> > for me it fixes :
> > * crash during filtering
> > * crash when looking at an imap folder and switching to a non imap folder
> > * crash while deleting a file
>
> This is ok but I wonder why the message is null.

Someone in #kontact had the same crashes today (on debian). I've dug a bit and 
with his help (thanks Max :) and especially the guru input of Lubos Lunak, 
we've been able to establish that the culprit is apparently a failing 
static_cast from KMMsgBase to KMMessage. Since KMMessage inherits KMMsgBase 
privately these days, that cast is illegal, and the fact that it succeeds on 
my system and (judging from a quick survey on irc) most others must be 
attributed to chance and/or a gcc bug.

There are five of these casts in current head, grep tells me.

So, do we revert to public inheritance, thereby getting rid of:

public:
  // promote some of KMMsgBase's methods to public:
  using KMMsgBase::parent;
  using KMMsgBase::setParent;
  using KMMsgBase::enableUndo; // KMFolder
  using KMMsgBase::setEnableUndo; // dto.
  using KMMsgBase::setEncryptionStateChar; // KMAcct*
  using KMMsgBase::setSignatureStateChar; // dto.

as well? The above needs to be extended for my pending multiple status patch, 
btw. I do appreciate the goals Marc is following with these changes, but for 
the moment they seem to cause additional problems.

Cheerio,

Till
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/AaEPtrsWGirveVsRAmBEAJ0Zjatz0rCpKkEyEbMn5TGz4V/WMQCfRPHC
2IJm7jCipBT8zZF6nCekDk8=
=avcB
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]