[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Small bug
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2003-06-12 22:08:56
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 11 June 2003 23:21, Carsten Burghardt wrote:
> I just stumpled over a little thing and just want to confirm this.
> In kmfolder::countUnread we have this
>
> ...
>   if (mUnreadMsgs > -1)
>     return mUnreadMsgs;
>
>   open(); // will update unreadMsgs
>   close();
>   return (mUnreadMsgs > 0) ? mUnreadMsgs : 0;
>
>
> As close sets mUnreadMsgs = -1 this is a bug, isnīt it?

Obviously. Good catch.

> It works with 
>
>   open();
>   int unread = mUnreadMsgs;
>   close();
>   return (unread > 0) ? unread : 0;

Please commit.

Regards,
Ingo


[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]