[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Moving code around from reader to object tree parser.
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2003-06-02 19:47:22
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 02 June 2003 16:52, Marc Mutz wrote:
> reader win:
> - Use HtmlStatusBar instead of home-brewn QLabel.

Thanks! I always wanted to do this. (1)

> object tree parser:
> - Extract Method on processFooType to get processFooBarSubtype
>   methods.

Thanks! (cf. (1))

> - Use AttachmentStrategy::inlineNestedMessages()

See my other message.

> There is one known regression (documented with a FIXME)
> (see last hunk of kmreaderwin.cpp):
>
> I had to #if 0 a call to writeBodyStr. This code needs to be ported
> to use ObjectTreeParser first. The code is about the "view
> attachment" feature.
>
> Other than that, the changes should be behaviour-preserving (except
> for the smart attachment mode now showing nested messages inline).
>
> The patch is large, but consists almost purely of moving around code.

Looks good. But the patch would have been more readable if you wouldn't 
have made all those "if(" -> "if (", etc., changes. Luckily, diff can 
completely ignore white spaces.

Regards,
Ingo


[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]