[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [Bug 56770] kmail crashed using DCOP
From:       Zack Rusin <zack () kde ! org>
Date:       2003-04-28 17:30:43
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
     
http://bugs.kde.org/show_bug.cgi?id=56770     
zack@kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From zack@kde.org  2003-04-28 19:30 -------
Subject: kdepim/kmail

CVS commit by zrusin: 

Crash fix. Do not try to schedule a non-existing job (job created with a 
malformed url).
CCMAIL: 56770-done@bugs.kde.org


  M +0 -2      imapjob.cpp   1.9
  M +6 -0      kmcomposewin.cpp   1.688


--- kdepim/kmail/imapjob.cpp  #1.8:1.9
@@ -229,6 +229,4 @@ void ImapJob::slotGetMessageResult( KIO:
       msg->setComplete( TRUE );
       emit messageRetrieved(msg);
-    } else {
-      emit finished();
     }
     msg = 0;

--- kdepim/kmail/kmcomposewin.cpp  #1.687:1.688
@@ -3682,4 +3682,10 @@ QCString KMComposeWin::pgpProcessedMsg(v
 void KMComposeWin::addAttach(const KURL aUrl)
 {
+  if ( aUrl.isMalformed() ) {
+    KMessageBox::sorry( 0, i18n( "<qt><p>KMail couldn't recognize the location of \
the attatchment (%1).</p>" +                                 "<p>You have to specify \
the full path if you wish to attach a file.</p></qt>" ) +                        \
.arg( aUrl.prettyURL() ) ); +    return;
+  }
   KIO::TransferJob *job = KIO::get(aUrl);
   KIO::Scheduler::scheduleJob( job );
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]