[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] yet more threading fixes and fixes for search folders
From:       Till Adam <till () adam-lilienthal ! de>
Date:       2003-04-05 8:56:56
[Download RAW message or body]

On Saturday 05 April 2003 08:21, Zack Rusin wrote:
> On Friday 04 April 2003 12:43, Till Adam wrote:
> > On Sunday 30 March 2003 23:34, Till Adam wrote:
> > > On Sunday 30 March 2003 18:11, Till Adam wrote:
> > > > The second, searchFoldersAndImap.diff contains changes necessary
> > > > to make search folders work correctly with imap folders. It
> > > > implements getMsg() for search folders by forwarding the request
> > > > to the folder of origin of the message.
> > >
> > > I've extracted that part and extended it with an implementation of
> > > KMFolderSearch::ignoreJobsForMessage( KMMessage* msg ) which
> > > appears to be also needed.
> >
> > New version attached. This adds updating of search folders when mail
> > arrives in imap folders (when the folder the new mail arrives in is
> > open or when it is opened after mail arrival). Any better way to
> > solve this?
>
> I think we already talked about the kmfolderimap change on irc. I'm
> perfectly happy with it.

Yes, although my first solution, which I talked to you on irc about was 
actually wrong. There is no need to emit the other msgAdded signals, this one 
should be sufficient.

> As far as search folders go, I'm not quite
> sure about those changes. Code wise they're right on target except the
> ignoreJobsForMessage. In imap they're handled a little differently
> because the account manages them but in other folders they're managed
> simply by the folders. You're removing only jobs for imap folders while
> the rest stays in, you need to forward the ignoreJobsForMesage to
> KMFolderSearch parent (KMFolder) or else the jobs will stay in the
> mJobList list in KMFolder ( in general ignoreJobsForMessage needs a
> rewrite anyway, I know it doesn't do too much at this point, but for
> now just forward it to the parent).

Ah, ok. Missed that. I'll add a #define KMFolderSearchInherited KMFolder then, 
for that purpose?

> All in all, feel free to commit
> after correcting that one problem. Thanks :)

Will do.

Till
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]