[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: adding timestamp to transmission completed statusbar message
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2003-03-09 23:22:21
[Download RAW message or body]

On Sunday 09 March 2003 14:19, Patrick S. Vogt wrote:
> On Saturday 08 March 2003 18:51, you wrote:
> > On Saturday 22 February 2003 19:05, Patrick S. Vogt wrote:
> > > Here is a small patch that adds a timestamp to the transmission
> > > completed message.
> >
> > The patch looks good except for:
> > +  KLocale locale("kmail");
> > +  statusMsg.append( " (" + locale.formatDateTime(
> > QDateTime::currentDateTime() ) + ")" );
> >
> > You should use
> >   KLocale* locale = KGlobal::locale();
> >   statusMsg.append( " (" + locale->formatDateTime(
> > QDateTime::currentDateTime() ) + ")" );
> > instead.
>
> Take the time formating from the global settings instead of the kmail
> settings?

Yes. KMail doesn't have an own setting for the time format.

> > Do you have a cvs account? Or should I commit your patch?

> no, I do not have a cvs account, please commit.

Done. BTW, I put the time before the status message and I decided that 
showing only the time (without date, but with seconds) suffices.

Regards,
Ingo


[Attachment #3 (application/pgp-signature)]
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]