[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [Bug 48888] click on a folder and then move the mouse may selects wrong folder
From:       Don Sanders <sanders () kde ! org>
Date:       2003-02-07 5:26:38
[Download RAW message or body]

On Thursday 06 February 2003 08:12, Ingo Klöcker wrote:
> On Monday 03 February 2003 10:35, Don Sanders wrote:
> > On Monday 03 February 2003 02:38, Ingo Klöcker wrote:
> > > On Sunday 02 February 2003 11:20, Don Sanders wrote:
> > > > The other keyboard navigation problems I refer to are the
> > > > ctrl-left, ctrl-right, ctrl-space folder
> > > > navigation/selection. I don't consider breakage of this a
> > > > major bug, do people really want me to back port that?
> > >
> > > Hmm, keyboard folder navigation/selection works without
> > > problems with KMail 1.5. According to the cvs log you broke
> > > this with your workaround for bug 48888.
> >
> > ctrl-left/ctrl-right should change the current item (but not the
> > selected item) in the folder tree.
>
> It does.
>
> > ctrl-space should change the selected item, and update the folder
> > shown in kmheaders.
>
> It does.
>
> > IIRC this is broken in KMail 1.5.
>
> You remember incorrectly. It definitely works this way in KMail
> 1.5.
>
> > > BTW, your fix results in many selected folders if the user drag
> > > selects several folders (click and hold left mouse button and
> > > then move the mouse over several folders). In KDE 3.1 always
> > > only one folder is selected if the user holds the mouse button
> > > down while he moves over the folder pane.
> >
> > Yes that would be nice, but surely this improvement is less
> > important than working keyboard navigation.
>
> As keyboard navigation _does_ work in KMail 1.5 there is no reason
> not to revert your workaround (which introduced the aforementioned
> regression) now that the real bug is fixed in Qt.
>
> > > IMO we should revert your workaround (which introduces very low
> > > level event handling which is much better done in QListView
> > > itself) and instead rely on the fix in Qt which I have just
> > > committed to qt-copy.
> >
> > It is not actually a work around if it also fixes the navigation
> > behavior as described above.
>
> No, it does not. It does only fix what your workaround broke. At
> least that's what you said yourself in the cvs log:
> =====
> Date: 13.11.02 10:33
>
> CVS commit by sanders:
>
> My change to fix accidental folder changing broke normal listview
> navigation in the foldertree make, so fix that.
>
>   M +13 -10    kmfoldertree.cpp   1.199.2.17
> =====

I see. In that case my change is a workaround and I can't foresee any 
problem with reverting it. 

That is assuming that the fix in qt has already been released in an 
official Qt release. I can't support reverting my workaround until 
the fix in Qt has been officially released.

Don.

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]