[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [Bug 48888] click on a folder and then move the mouse may selects wrong folder
From:       Don Sanders <sanders () kde ! org>
Date:       2003-02-03 9:35:28
[Download RAW message or body]

On Monday 03 February 2003 02:38, Ingo Klöcker wrote:
> On Sunday 02 February 2003 11:20, Don Sanders wrote:
> > On Sunday 02 February 2003 13:01, Tim Wunder wrote:
> > > On Saturday 01 February 2003 12:25 pm, someone claiming to be
> > > Ingo Klöcker
> > >
> > > wrote:
> > > > On Thursday 30 January 2003 06:54, Don Sanders wrote:
> > > > > IIRC the fix in KMail also fixes some other problems with
> > > > > keyboard navigation that the fix in Qt does not.
> > > >
> > > > Do you think it's possible to backport the fix to KDE 3.1? If
> > > > yes, could you please do so.
> > >
> > > Yes, please do so :-)
> >
> > The other keyboard navigation problems I refer to are the
> > ctrl-left, ctrl-right, ctrl-space folder navigation/selection. I
> > don't consider breakage of this a major bug, do people really
> > want me to back port that?
>
> Hmm, keyboard folder navigation/selection works without problems
> with KMail 1.5. According to the cvs log you broke this with your
> workaround for bug 48888.

ctrl-left/ctrl-right should change the current item (but not the 
selected item) in the folder tree.

ctrl-space should change the selected item, and update the folder 
shown in kmheaders.

IIRC this is broken in KMail 1.5.

> BTW, your fix results in many selected folders if the user drag
> selects several folders (click and hold left mouse button and then
> move the mouse over several folders). In KDE 3.1 always only one
> folder is selected if the user holds the mouse button down while he
> moves over the folder pane.

Yes that would be nice, but surely this improvement is less important 
than working keyboard navigation.

> IMO we should revert your workaround (which introduces very low
> level event handling which is much better done in QListView itself)
> and instead rely on the fix in Qt which I have just committed to
> qt-copy.

It is not actually a work around if it also fixes the navigation 
behavior as described above.

Don.

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]