[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [Bug 53156] Kmail compacting folders dialog box too small on exit
From:       Scott Wheeler <scott.wheeler () sap ! com>
Date:       2003-01-21 11:46:56
[Download RAW message or body]

On Tuesday 21 January 2003 00:29, Ingo Klöcker wrote:

> It's not centered on purpose. A centered progress dialog is too
> distracting if you want to continue doing something else while KMail is
> shutting down. FYI, the first version of the clean up dialog was
> centered.

Ok, I think I remember it being centered and noticed the change and thought it 
was a bug.  ;-)  I wondered if there just wasn't placement code and it was 
just showing up wherever it pleased.  ;-)

> I don't think de-uglification is necessary. But we are nevertheless open
> for suggestions (in form of patches).

Ok, well the attached patch fixes at least makes the border a little nicer and 
fixes the bug that I replied to.

The problem was that mProgress was reporting a width() of ~700 and the call to 
mPopupCleanup->adjustSize() wasn't picking up on this.  However, even when I 
adjusted the size manually (using the width of the widgets contained) it 
quickly became obvious that 700 pixels is a bit wide for the progress bar, 
which I guess is what it's giving as it's size hint. ;-)

Trivial patch attached.  Ok to apply?

-Scott

-- 
Scott Wheeler
SAP LinuxLab
Neurottstraße 16
69190 Walldorf, Germany
(+49) 6227 7-44804
["kmail-cleanuppopup.patch" (text/x-diff)]

Index: kmkernel.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/kmkernel.cpp,v
retrieving revision 1.158
diff -u -3 -p -r1.158 kmkernel.cpp
--- kmkernel.cpp	14 Jan 2003 19:13:58 -0000	1.158
+++ kmkernel.cpp	21 Jan 2003 11:39:55 -0000
@@ -844,7 +844,12 @@ void KMKernel::cleanupLoop()
     mProgress->setTotalSteps(nrFolders*2+2);
     mProgress->setProgress(1);
     QApplication::syncX();
-    mCleanupPopup->adjustSize();
+
+    mCleanupPopup->setFrameShape( QFrame::PopupPanel );
+    mCleanupPopup->setFrameShadow( QFrame::Raised );
+
+    mProgress->setFixedWidth( 150 );
+
     mCleanupPopup->show();
     kapp->processEvents();
     connect(the_folderMgr, SIGNAL(progress()), this, SLOT(cleanupProgress()));

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]