[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] for bug 49603
From:       chester_b <chester_b () ithryn ! net>
Date:       2001-01-01 16:27:23
[Download RAW message or body]

On Friday 01 November 2002 09:20 am, Michael Häckel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Monday 28 October 2002 03:33, chester_b wrote:
> > Hi All,
> >
> > Here's a patch that i created (attatched). If there's anything wrong with
> > it let me know. The patch was created with 'cvs diff -u kmheaders.cpp'
>
> Thanks for the patch. Sorry for the late reply.
no problem.

>
> Don't you think, there is a way to do this with less code duplication?
> Also QListViewItem::itemAbove() is a time consuming function and should
> therefore not be called unneccesarily twice (QListViewItem::itemBelow() is
> fast).

I figured there was a more efficient way to get the job done. I was of the 
mentality that i would change and add as little code as possible to be safe i 
don't introduce a regression so late in a release cycle.

I wasn't aware of how expensive QListViewItem::itemAbove() was. I will use 
your suggestion and come up with another patch within a few days.

-b
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]