[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Patch to get rid of another useless warning.
From:       Karl-Heinz Zimmer <khz () kde ! org>
Date:       2002-09-30 11:34:15
[Download RAW message or body]

Hi all,

any objections against me applying the following patch to KMail CVS?

The "ownIndent" parameter obviously is left from a way how things used to
be handled before the current implementation of quoting was made: If I am
not wrong it does not serve any purpose today, so we by removing it could
get rid of a compile time warning without loosing anything.

OK for you?  :)

Karl-Heinz
-- 
Karl-Heinz Zimmer, Senior Software Engineer, Klarälvdalens Datakonsult AB
<mailto:khz@klaralvdalens-datakonsult.se>            <mailto:khz@kde.org>

["remove_unused_param.patch" (text/x-diff)]

Index: kmmessage.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kmail/kmmessage.cpp,v
retrieving revision 1.325
diff -u -r1.325 kmmessage.cpp
--- kmmessage.cpp	2002/09/29 19:02:30	1.325
+++ kmmessage.cpp	2002/09/30 10:57:02
@@ -601,7 +601,7 @@
   }
 }
 
-static void smartQuote( QString &msg, const QString &ownIndent, int maxLength )
+static void smartQuote( QString &msg, int maxLength )
 {
   QStringList part;
   QString oldIndent;
@@ -830,7 +830,7 @@
     result = indentStr + result + '\n';
 
     if (sSmartQuote)
-      smartQuote(result, indentStr, sWrapCol);
+      smartQuote(result, sWrapCol);
 
   } else {
     result = "";
@@ -888,7 +888,7 @@
       part.replace(reNL, '\n' + indentStr);
       part = indentStr + part + '\n';
       if (sSmartQuote)
-        smartQuote(part, indentStr, sWrapCol);
+        smartQuote(part, sWrapCol);
       result += part;
     }
   }

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]