[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] increase moveMsg performance
From:       Carsten Burghardt <cb () magic-shop ! de>
Date:       2002-09-06 17:03:40
[Download RAW message or body]

On Friday 06 September 2002 08:49, Don Sanders wrote:
> On Friday 06 September 2002 15:35, Carsten Burghardt wrote:
> > On Thursday 05 September 2002 20:15, Michael Häckel wrote:
> > > On Tuesday 03 September 2002 22:34, Carsten Burghardt wrote:
> > > > - implemented a countUnreadRecursive method in kfoldertree
> > > > (already committed) which was virtual before. This fixes the
> > > > first part of this display-problem because it makes sure that
> > > > the displayed unread-count is really taken. Apart from that it
> > > > should be faster than the old one.
> > > >
> > > > - removed my disconnect statement in KMHeaders::readSortOrder
> > > > (from the scrolling patch). This fixes the second part from the
> > > > display-problem and the above mentioned problem. If you
> > > > selected the folder and the content was not 'getted' before,
> > > > the current message wasn't displayed. If you selected a
> > > > different folder and then the original again it worked. Very
> > > > strange this whole readSortOrder-code.
> > >
> > > Don wrote that code and claims to help every developer when he
> > > has any problems.
> >
> > Well then Don, the old fix with a disconnect doesn't work. Any
> > better idea?
>
> A disconnect should work fine if you do it right.

That's a nice argument ;-)

> It would help a lot if I knew how to reproduce this bug. Can you
> describe how to reproduce this problem with a message being scrolled
> to the top?

OK, comment out the disconnect/connect part in kmheaders::readSortOrder.
Select your imap-inbox, select a message, scroll down, send yourself a 
message.
Check for new messages, the new one arrives, the saved item is setted and your 
currently viewed message is loaded again, therefore scrolled up. You might 
need to play a little around (like first select a different folder) but it 
works.
The problem with this disconnect is that
a) it's a hack
b) it doesn't work with my patch because of the already described problem

-- 
Regards,

Carsten Burghardt
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]