[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Kpgp problem (here's the patch)
From:       Carsten Pfeiffer <carpdjih () cetus ! zrz ! tu-berlin ! de>
Date:       2002-09-04 11:20:18
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----

Hi,

(Don, please keep CCing me, I'm not subscribed -- only found this via 
lists.kde.org)

> Sorry I'm not quite sure what you are saying yes to.
> 
> First I would like to remove the mCryptPlugList member variable from 
> KMComposeWin, this should be safe.
> Secondly I don't undertand why configuredialog still uses a 
> mCryptPlugList. Locally I've removed this, as you can see in the 
> attached patch. But I'm not sure if this is safe because I haven't 
> been able to get the crypt plugins to work so I can't test it.
> 
> I think this is the riskiest part of the patch I have waiting to 
> commit so I want to work this out before committing the rest of my 
> patch.

You can safely do this, it's just taking some more method calls 
(KMKernel::self()->cryptPlugList() for every access instead of just 
dereferencing a pointer).

Otherwise it's just the same. There is just one single instance of the 
CryptPlugWrapperList.

PS: You missed to remove one "_pluginPage->" in your patch:

 -         wrapper = _pluginPage->mCryptPlugList->next(), ++i ) {
+         wrapper = _pluginPage->kernel->cryptPlugList()->next(), ++i ) {

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPXXsdKWgYMJuwmZtAQEdbAf/VP2a3FEuhw4wIUsO13EO74004IjcJGUC
NeQy95NfpOyjXYpfoUvNezHDhk++CSf9mtqH4ZLHUcX+8o2gw1Y6zC+43Pyiixzc
nW+5QZ+amCsAXwPA8K0zrZRNKIq0pewwd3bfSLgOVqUVmTtPUUJxzoRAQcU/Vvku
XkRXBHlpO5vbTRKftIfkZb3GBF3YupjDZo0/wKtKXzy8rou9T9EwJP476DUDWXp+
ViYlaNfYkXHCqXPUsg9rMpCOfcdBdIBl3NuWXLMgUTmHsvH2UistJHc+Gd8jatbO
o6C4Bqrm+pTyo5jx6VWC4fBfWYu03ktK675UeB38ipp7EvVpSaG1Xg==
=5YZ8
-----END PGP SIGNATURE-----
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]