[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] fix bug 43417
From:       Michael =?iso-8859-1?q?H=E4ckel?= <haeckel () kde ! org>
Date:       2002-09-03 19:43:50
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 01 September 2002 11:33, Carsten Burghardt wrote:
> > Ok, we could maybe agree, that the IMAP slave always returns
> > ERR_CANNOT_ENTER_DIRECTORY if SELECT or STATUS fail and that this error
> > message is reservered for that, but this should be documented then.
>
> Right, that's what I wanted. Can you change that in the kioslave for these
> two commands (you know that thingy better)? My part would then look like
> the attached one.

Done. It took some time because I had to prevent KMail from crashing first,
when an error appears to actually test it.
However I decided to use ERR_DOES_NOT_EXIST instead and make the IMAP slave
doing some additional research with a LIST command if SELECT or STATUS fail.
This requires the same list command executed again later but otherwise
correct error reporting is impossible. If SELECT fails but the folder does
exist the human readable part of the error message from the server should be
presented to the user and this basically only works with ERR_NO_CONTENT where
I'm able to specify the complete text.

ERR_DOES_NOT_EXIST now definitely means that a folder does not exist
according to LIST.

> A list-command _before_ selecting the folder?

Right and also in a lot of other cases where it is not neccesary. Mainly just
to find out if the folder can contain messages, subfolders or both.

Your patch looks good besides the now required error code change.

Regards,
Michael Häckel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9dRD3e9KEPyN2R8URAj+/AJ9dwq/ddiBAmUxrJEWG/F9bqqqlAwCfVwQ/
c4pB4FmpzzMWNw8YgWV4zzk=
=Wig5
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]