[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Move Configuredialog from KMMainWin to KMKernel
From:       Marc Mutz <mutz () kde ! org>
Date:       2002-09-01 17:13:09
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 01 September 2002 16:45, Ingo Klöcker wrote:
<snip>
> I'd like to move the configuration dialog to the kernel.

Fine with me.

> Reasons:
<snip a>
> b) More importantly, the configuration dialog can also be opened from
> the composer.
<snip>

Can it? ;-)

> The only drawback is that the configuration dialog doesn't have a
> parent anymore (because KMKernel is no QWidget). But AFAIK this
> influences only the placement of the dialog.
<snip>

And the stay-on-top w.r.t. the parent. But that was something that 
bugged me quite often already.

The bigger drawback is that you now have to care about deleting it 
yourself *hint*hint*

Oh, and slotShowConfigurationDialog() looks a bit ugly (to me). I'd use

if ( !mConfigureDialog )
  mConfigureDialog = new ConfigureDialog(...);
if ( mConfigureDialog->isHidden() )
  mConfigureDialog->show();
else
  mConfigureDialog->raise();

(yes, it has new stuff in it, too).

Marc

- -- 
If free-software authors lose the right to disclaim all warranties and
find themselves getting sued over the performance of the programs
they've written, they'll stop contributing free software to the world.
 -- Bruce Perens: Open Sources: Voices from the Open Source Revolution
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9ckqm3oWD+L2/6DgRAvxwAKDN+Ndxjg520nZH0Ew7nM964Wfq3gCbBu1q
WLauCxAKQmz4pBJM0uxtzac=
=LWa9
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]