[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: GUI consistency
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2002-09-01 10:27:08
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 01 September 2002 10:33, Don Sanders wrote:
> On Friday 30 August 2002 21:22, Marc Mutz wrote:
> > On Friday 30 August 2002 06:02, Don Sanders wrote:
> > > Bummer, this will create many conflicts for me.
> >
> > So what? It does for everyone who has non-trivial patches applied
> > locally.
>
> cvs conflicts are a problem because they introduce the possibility
> that I'll make an error when resolving them and add more work for me.

So? Marc already said that "everyone who has non-trivial patches" 
waiting to be commited has the same problems as you.

> I mean it wouldn't make sense to reformat all the tabbing in files
> to make then consistent when I have a large patch outstanding.

Is anyone reformatting the tabbing?

> And this is a pretty large patch I have waiting.

You are not the only one. Maybe you patch is the largest though.

> It also doesn't make sense for me to withhold my cleanup when other
> cleanups are being committed.

The cryptPlugList "cleanup" is more of a bug fix. And the GUI cleanup 
can't possibly break any functionality in KMail. But your large patch 
makes heavy changes to KMail's core and might very well have undesired 
side-effects (although probably there won't be any).

Please don't misunderstand me (and Marc). We are not against your 
cleanup. We are actually all for it. We just doubt that it's wise to 
commit the cleanup now. But if you think it's safe enough then I won't 
stop you from commiting it.

> Once the cryptPlugList changes are made I'll commit my cleanup with
> the new features "#if 0" out.

So now it's 'First come, first commit'?

Please note that the GUI cleanup has to be commited today because 
tomorrow begins the message freeze.

Regards,
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9ceuIGnR+RTDgudgRAvMqAKCqx72ba+ZGOgwHjavcy8rSAMVQBQCgp5uS
t+4X1Gxm+m9k4L7zGhl4Cio=
=SRcU
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]