[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: gpg bug in kmail / libkdenetwork
From:       Thomas Reitelbach <tr () erdfunkstelle ! de>
Date:       2002-06-28 14:55:55
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 28 June 2002 00:54, Ingo Klöcker wrote:

> Quotes in the user name are very unusual (I never saw any key with a
> quoted user name) and moreover completely unnecessary. Nevertheless
> KMail should of course handle this correctly.

Not so unusual i think. I've seen this in some cases now. also, as i 
explained, one could make a mistake and exactly follow the (german) example 
from GnuPG (which uses quotes).

> > My patch will make libkdenetwork really search for the the text
> > between first and last ".
> >

> Thanks for your patch. Unfortunately I think it's not the best solution.
> Your patch searches for the last " in the whole output of GnuPG. But
> probably there might be more quotes. It would be better to first look
> for the line break ('\n') after the first " and then search backwards
> for the last " in this line. I fixed the code accordingly, i.e. I
> replaced
>   index2 = error.find('"', index+1);
> by
>   index2 = error.find('\n',index+1);
>   index2 = error.findRev('"', index2-1);

I've found this today, too.
Well, here you can see that i'm a newbie with this, that's why i asked you to 
have a look at it.

> The diff was o.k. But the next time please send us a patch in unified
> output format (diff -u). You should add the following lines to your
> .cvsrc:
> cvs -z4 -q
> diff -u3 -p
> update -dP
> checkout -P
>
> And then you should generate patches against CVS with 'cvs diff
> <filename>'.

ACK, i'll keep this in mind.

bye,
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9HHj/+83LmoKU5MARAgLEAJ0XyIzUksbqzWxkBXjzDKgz/kepEwCfXIgB
s9R6v2B5+uhHlZREqpcDf4A=
=HBjz
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]