[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] foldertree rework
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2002-06-24 20:55:34
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 23 June 2002 23:34, Carsten Burghardt wrote:
> I added a new version of kfoldertree to CVS. After some conversation
> with Marc I removed all the stuff that doesn't belong to a widget and
> therefore depends on kmail/knode. Each KFolderTreeItem holds
> - the protocol of the (optional) associated folder
> - the unread and total count
> The class then cares for the correct painting.
> The attached patch uses this new class.
> An empty folder is shown when the user clicks on "Local Folders".

Very good work so far.

Nevertheless I have some comments:
- - when an empty folder is selected then the mimetree shouldn't be shown 
(in smart mode).

- - the popup menu which appears when the user right-clicks on the header 
in the folder/header pane should popup where the mouse is but not in 
the middle of the header (as in the case of the header pane) or right 
of the header (as in the case of the folder pane).

- - The action "Create Child Folder..." in the RMB menu of "Local Folders" 
should IMO be renamed to "Create Folder...".

Apart from this your patch looks very good and is IMO ready for being 
committed.

Regards,
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9F4dLGnR+RTDgudgRAojdAKDRXDj3VyYKOgH7D3QZRe4aFgpV1ACbBfyF
JrQC4ddVpFuA0AAlPHRaS7s=
=aYgR
-----END PGP SIGNATURE-----
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]