[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Re2: [PATCH] foldertree rework
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2002-06-16 19:04:21
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 16 June 2002 19:01, Carsten Burghardt wrote:
> On Saturday 15 June 2002 20:08, Ingo Klöcker wrote:
> > > I remember something about moving the configurable-part (which is
> > > reverted by this patch) to the kde-control-center. If that is not
> > > the case that it would be very good if someone could help me with
> > > that or even implement it. My main-focus is on the
> > > re-organization of the foldertree (which is done by this patch).
> >
> > Attached is a patch which implements the dnd behaviour we agreed
> > upon (or at least that's the decision I remember). The patch has to
> > be applied on top of Carsten's patch_foldertree_rebuild9.diff.gz.
>
> Looks good, thanks.
> I noticed a bug in KMMainWin::folderToPopup. It doesn't iterate over
> all root-nodes so imap-folders are not shown anymore because of the
> restructuring. I somehow do not manage to get a correct recursion
> with a QListViewItemIterator. Can anybody give me a hint?

You are talking about KMMainWin::folderToPopupMenu, right?

The problem is that this function assumes that there is only one entry 
on root level. You have to rewrite the recursion to also loop over the 
root elements. Currently we loop over the children of the current node 
because of the fti = ...(fti->firstChild()) directly before the loop. 
It would be better to loop over the current level and call the 
recursion with the children.

Regards,
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9DOE2GnR+RTDgudgRAlcDAKCc/zia9sEKlrv9gZL2sFukX44niwCeMYAy
qQptj/51+34KezeF0pjTAZo=
=YomP
-----END PGP SIGNATURE-----
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]