[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] forward multiple messages
From:       Michael =?iso-8859-1?q?H=E4ckel?= <haeckel () kde ! org>
Date:       2002-06-05 16:41:17
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 04 June 2002 23:57, Carsten Burghardt wrote:
> As there's one KMImapJob per Message I can't hide the progressbar but I can 
> advance it normally. That works (the progressbar goes away automatically 
> after all the jobs are done) but the action (reply, forward, ...) continues 
> normally and the new messages is created (see the attached patch).

Sorry, but simply ignoring the error is not correct error handling.

> Advantage: if there's (for example) only one message where the transfer
> fails then the other messages are transferred normally, unless the user
> cancels it

This case probably can happen, if the cached headers are not in sync with the
folder on the server and some mails have been deleted meanwhile.

If the user want to forward five message and only one is available, this is
not a real advantage.

> The best way would be probably to let the user decide it the transfer
> should contiue. But then I need to know if the KMImapJob succeeded or not.

I don't think so. Either it works or forwarding should fails completely and
force the user to retry. Independant of that, seeing a no longer existing
message should probably trigger a folder refresh.

If the KMImapJob is deleted before a messageRetrieved() signal is emmitted,
the transfer was obviously not successful.

Alternatively the KMImapJob could get a flag that is sent with the finished()
signal, but I don't think this is neccessary.

Regards,
Michael Häckel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE8/j8te9KEPyN2R8URAg8EAJoCYHyCK1oYsklWUKcd4UIXuSBlTACfejxw
r72/j2AxazFbFLbzQlr7Zuo=
=8Eo+
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]