[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] foldertree cleanup
From:       Zack Rusin <zackrat () att ! net>
Date:       2002-05-05 16:20:29
[Download RAW message or body]

On Sunday 05 May 2002 08:56, Karl-Heinz Zimmer wrote:
> On Sunday 05 May 2002 14:10, Carsten Burghardt wrote:
>
> ..
>
> > I did _not_ touch the dnd-stuff yet.
> > Zack and khz, I think I need your help in this case. We should
> > somehow move the current dnd-stuff to libkdenetwork (or even to
> > klistview?) to make use of this code e.g. in knode. Ideas?
>
> ACK.
>
> _But_ please wait until we have fixed the remaining '+' sign problem:
> it seems to look like using dragCopy() and dragMove() is /not/ the
> best idea since it inhibits auto-detect of pressed/released keyboard
> modifiers.
>
> What we actually do need is a way to have Qt react on keyboard
> changes during drag operation _and_ show the '+' sign at the key _we_
> specify at beginning of the drag operation!
>
> I am sure there will be a good solution for this but please do not
> put ur incomplete code on another level of the source hierarchy until
> this is fixed!

Hmm, well I can fix it in one of the two ways:
a) pure Xlib way,
b) QT way,
Both are nasty. The first one would involve squeezing some event 
processing in between QDragObject and QDragManager, two very closely 
coupled objects. Very infringing solution (towards QT internals). 
Solution b involves adding three files to KMail source tree from QT - 
qdragobject.[cpp|h] and qdnd_x11.cpp. This way we could simply change 
QDragManager to our liking (we could even make the icons transparent 
this way), but like I said it adds three files to KMail, and basically 
it would mean that we have our own dnd implementation. There's no other 
way to do it. I'm not sure if I understand why in hell are we letting 
users choose what buttons are used for what action and what action is 
the default. Quite frankly I don't like it. I agree that adding '[x] 
don't show dnd popup' is OK, but not the others. Even if we solve the 
modifier problem, we're going to introduce a problem for maintainers of 
all other applications, who will get reports from users who will like 
our behavior to change their apps to do the same. Besides was there 
anyone who ever complained : "I often press random keys during 
drag&drop operations, and even though I always want to move messages I 
sometimes press and hold CTRL while dropping and it just messes me up, 
please change it!" ;) 

Zack

-- 
God is REAL, unless explicitly declared INTEGER.

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]