[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Fixes Bug#39626: kmail silently (!) stops saving huge attachments after ~ 1MB is written
From:       Stephan Kulow <coolo () kde ! org>
Date:       2002-04-02 10:15:35
[Download RAW message or body]

On Friday 29 March 2002 14:06, Ingo Klöcker wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> this bug was caused by the fact that the size of huge attachments
> doesn't fit in 6 hex digits (the KIO connection uses %6x for the
> length). An ugly hack was introduced in KDE 3.0.1 to fix this. But it
> was agreed that KMail shouldn't write all data at once.
>
> Waldo wrote:
> > The solution is to send smaller chunks, something like 64Kb or so.
> > Sending 10Mb in a single chunk is a design error on the part of the
> > application.
>
> So sending the data in smaller chunks is what the attached patch does.
> I tested it with small attachments (< 64 KB) and huge attachments (up to
> 19 MB).
>
> Please review!

Why do you need to do duplicate()? assign() should do - and be faster and less
memory hungy, even though the memory problem is limited to 64KB now :)

In any way commit to 3.01. 

Greetings, Stephan

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]