[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Abstracting date handling.
From:       Zack Rusin <zackrat () att ! net>
Date:       2002-03-31 7:30:08
[Download RAW message or body]

On Saturday 30 March 2002 06:49, Ingo Klöcker wrote:
> You are missing that dateStr is set a little bit further down in the
> while-loop. The if-branch which contains the
> message->setDate(dateStr); is only executed if a message has been
> read completely and in this case dateStr is set to the value of the
> Date: header of this message (unless the Date: header was missing).
>
> So these lines must not be removed. But the following inconsistency
> should be removed:
> In kmfoldermbox.cpp:
> 	  mi->setDate(dateStr);
> In kmfoldermaildir.cpp:
>       if (!dateStr.isEmpty())
>         mi->setDate(dateStr);
>
> Unfortunately I don't know which one is correct.
>

Sorry about that. I checked it, they're both fine actually. Although 
during the first iteration DwHeader in mimelib will set the date header 
to null it's not a problem because even if we did get out of that loop 
at that time we check for a null header when displaying the date. So 
they're both fine. Checking for the empty string right in the loop is 
somewhat more cleaner and 9nsec faster (machine dependant) ;) , but not 
checking it doesn't break anything.

Zack

-- 
Does this .sig make my butt look big?

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]