From kmail-devel Wed Feb 27 21:10:06 2002 From: Marc Mutz Date: Wed, 27 Feb 2002 21:10:06 +0000 To: kmail-devel Subject: Re: ATTN: translators [PATCH] fix accel clashes in mainwindows and important dialogs X-MARC-Message: https://marc.info/?l=kmail-devel&m=101484446014567 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--------------Boundary-00=_USM7YXXO8R55QWL9VFFL" --------------Boundary-00=_USM7YXXO8R55QWL9VFFL Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Wednesday 27 February 2002 19:32, Tamas Szanto wrote: > here are some minor i18n-related issues with KMail while you are > waiting for the permission to commit the patch ;-) > > 1) In the KMail settings dialog the following 3 strings are not > translated: "Sta&ndard format ()" > "Localized format ()" > "Fancy format ()" > Similar strings can be found in the .pot file, probably the original > strings have been modified a bit. Hm. I don't know why, but well, it should work with attached patch (we=20 need to attach all patches currently :-). > 2) At the Filtering settings, the "Subject", "From", "To", "Cc" ... > strings are not translated. Hm, should they? They represent header fields. And they are named in=20 english... Are the bracketed entries (eg. "" translated)? > 3) In the message headers the "Date" value is printed out using the > long English format. In the message list the date is properly > formatted. Known. I even think Coolo has it on his todo list ;-) > 4) The right button pop-up menu in the message edit windows is > untranslated (Undo, Redo, Cut, Copy, ...). Hm, that are strings from kdelibs, I guess. But a missing=20 KGlobal::locale()->insertCatalogue("kdeui") should produce many more=20 untranslated strings than that... > 5) (Not i18n-related) The "Message" menu has become way too long in > the latest KMail version: 23 items + separators. Could it be a little > shorter? Hehe. Think about how hard it was to find different accelerators for=20 each entry... I really hope we take back on featuritis for Kmail 3.1 and instead focus=20 on refactoring the code and reworking the GUI. But I don't hold my=20 breath :-( Marc - --=20 Marc Mutz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE8fUsv3oWD+L2/6DgRAl02AKCB/AMgpW1bfPEgFdh4fo2BvWL6lACgnQBA p31Q5fLePwaWuuFH8/Q3By4=3D =3DA7jT -----END PGP SIGNATURE----- --------------Boundary-00=_USM7YXXO8R55QWL9VFFL Content-Type: text/x-diff; charset="us-ascii"; name="kmail-fix-untranslated-strings.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="kmail-fix-untranslated-strings.diff" Index: configuredialog.cpp =================================================================== RCS file: /home/kde/kdenetwork/kmail/configuredialog.cpp,v retrieving revision 1.214 diff -u -3 -p -r1.214 configuredialog.cpp --- configuredialog.cpp 2002/02/21 18:34:05 1.214 +++ configuredialog.cpp 2002/02/27 21:09:42 @@ -2139,12 +2139,9 @@ QString AppearancePage::LayoutTab::helpA // hrmpf. Needed b/c I18N_NOOP can't take hints. const AppearancePage::LayoutTab::dateDisplayConfigType AppearancePage::LayoutTab::dateDisplayConfig[] = { - { "ctime", i18n( "Date format. %1: example date string", - "Sta&ndard format (%1)" ), CTime }, - { "localized", i18n( "Date format. %1: example date string", - "Locali&zed format (%1)" ), Localized }, - { "fancyDate", i18n( "Date format. %1: example date string", - "Fanc&y format (%1)" ), FancyDate }, + { "ctime", I18N_NOOP("Sta&ndard format (%1)"), CTime }, + { "localized", I18N_NOOP("Locali&zed format (%1)"), Localized }, + { "fancyDate", I18N_NOOP("Fanc&y format (%1)"), FancyDate }, }; AppearancePageLayoutTab::AppearancePageLayoutTab( QWidget * parent, const char * name ) @@ -2193,7 +2190,7 @@ AppearancePageLayoutTab::AppearancePageL time_t currentTime; time( ¤tTime ); for ( int i = 0 ; i < numDateDisplayConfig ; i++ ) - mDateDisplay->insert( new QRadioButton( dateDisplayConfig[i].displayName + mDateDisplay->insert( new QRadioButton( i18n(dateDisplayConfig[i].displayName) .arg( KMHeaders::formatDate( currentTime, dateDisplayConfig[i].dateDisplay ) ), mDateDisplay ), i ); Index: configuredialog_p.h =================================================================== RCS file: /home/kde/kdenetwork/kmail/configuredialog_p.h,v retrieving revision 1.11 diff -u -3 -p -r1.11 configuredialog_p.h --- configuredialog_p.h 2002/02/11 14:41:12 1.11 +++ configuredialog_p.h 2002/02/27 21:09:43 @@ -580,7 +580,7 @@ protected: static const int numDateDisplayConfig = 3; static const struct dateDisplayConfigType { const char * configName; - QString displayName; + const char * displayName; KMDateDisplay dateDisplay; } dateDisplayConfig[ numDateDisplayConfig ]; --------------Boundary-00=_USM7YXXO8R55QWL9VFFL-- _______________________________________________ KMail Developers mailing list kmail@mail.kde.org http://mail.kde.org/mailman/listinfo/kmail