[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: KMMsgDict slowness
From:       Carsten Burghardt <cb () magic-shop ! de>
Date:       2002-01-04 15:50:40
[Download RAW message or body]

Am Freitag, 4. Januar 2002 22:43 Ronen Tzur schrieb:
> On Wednesday 02 January 2002 07:40, Carsten Burghardt wrote:
> > On Tuesday 01 January 2002 17:31, Michael Häckel wrote:
> > > On Wednesday 02 January 2002 00:16, Ronen Tzur wrote:
> > >
> > > For IMAP it doesn't really matter, because there KMMessage usually
> > > contains only the headers, but for local folders it does.
> >
> > Well, this new method is the result of imap-improvements, as you know,
> > and just calls the old methods for compatibility. There is definitely
> > room for improvements. You can add a "QValueList<int> ids" and then
> > optimize this method for serial-number handling but it would be good not
> > to remove the QPtrList.
>
> Sorry for taking a while to respond but the whole time I wasn't sure what
> direction to work at -- improving the dictionary or the implementing group
> update.  Now that the critical speed issue is gone, I did start looking
> into a change along the lines described above.
>
> I'm thinking about adding a generic virtual
> KMFolder::removeMsgs(QValueList<int>), to be called by
> KMHeaders::moveMsgToFolder().  For IMAP folder, its implementation of
> removeMsgs() could prepare the list of QPtrList<KMMessage> and invoke the
> KMFolderImap::removeMsg() you did.  Sounds ok?

At first glance...yes.

-- 
Carsten Burghardt
email: cb@magic-shop.de
WWW: http://www.magic-shop.de
PGP: http://www.magic-shop.de/Carsten_Burghardt.asc
_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]