[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: KMMsgDict slowness
From:       Ronen Tzur <rtzur () shani ! net>
Date:       2002-01-04 9:00:16
[Download RAW message or body]

On Thursday 03 January 2002 13:55, Michael Häckel wrote:
> On Friday 04 January 2002 01:47, Ronen Tzur wrote:
> > Alright, that seem logical.   But I would have preferred to put this to
> > test.
>
> Well, if you don't believe that and want to prove the opposite by testing,
> I don't hinder you.

Alright, then please test the attached patch, I'm curious what kind of
an improvement you will see.  For me, moving 9000 messages now
takes 105 instead of 120 seconds.

I did not test the patch all that extensively but it seems to work.

It uses a new KMDict class instead of QDict.   KMDict is much better
than QDict.  :-)   I also tested KMDict a bit separately, so it should
be safe.

> > Without big problem is not so definate.  And, also in response your
> > following paragraph, "if it works why break it."
> >
> > Changing the way it works today, without a good enough reason, is
> > also a possible error source.   However, I know what we're really arguing
> > about here, is if the reason is actually good enough.
>
> Something in any case needs a change, either the dictionary or that code.

I've started looking into the change we discussed, and it really touches on
quite a few things.  A lot of opportunity to mess things up...  ;-)

> > Not really.  If the reverse dictionary holds the serial number itself,
> > or if it keeps a pointer to an object in the main dictionary (which
> > contains the serial number), what's the difference?
>
> If the objects in the main dictionary really contain the serial nubmers,
> then it indeed doesn't need more memory than before. However for what is
> the serial number stored at all in the main dictionary? Is this only forced
> by QDict?

Yep, forced.  And they don't even let you access that key if you want to.

["diff3.tar.bz2" (application/x-tbz)]
_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]