[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] rewrite of KMMsgPartDlg and fixincludes rant
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2002-01-04 0:26:05
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 03 January 2002 15:34, Marc Mutz wrote:
> Hi!
>
> This is the first part of a rewrite of KMMsgPartDlg (now
> KMMsgPartDialog{,Compat}).
>
> Details:
> - QDialog -> KMDialogBase
> - separated UI (KMMsgPartDialog) from functionality
> (KMMsgPartDialogCompat)
> - added Help button
> - added "Suggest automatic display", which controls the
> Content-Disposition header's value (inline|attachement).
> - added QWhatsThis all over the place
> - added "{Encrypt,Sign} this part" check boxes, add -DAEGYPTEN to see
> them.

Sounds all good.

> - added 7bit, binary encodings

WTF is binary encoding?

> - added the possibility to select uuencode (by default it's not
> shown)

uuencode? Are you insane? Maybe we should be able to decode uuencoded 
stuff but we should definitely never use this deprecated (at least 
since June 1992) encoding. Please let uuencode die gracefully!

> Known bugs in new code: none
> Known bugs in old code:
> - When attaching an .o file and calling up this dialog, base64 is
> selected. Selecting qp (or now binary), and hitting OK shrinks the
> file to seven byte, after a warning is printed that body is binary,
> but used as text. I don't know how this should have ever worked...
> Keeping binary data in QCStrings... I thought this bug was fixed long
> ago?

Is 0x00 allowed in Quoted-Printable? And what is binary supposed to be? 
Everything encoded with '0' and '1' ;-) ?

> To do:
> - Add config option to show or not to show the dialog on attaching.

I think we need a new configuration category: "Superfluous config 
options". Wouldn't it be enough if you, Marc, could enable it by 
editing kmailrc? I doubt that anyone except you will miss this annoying 
dialog. Anyway, do whatever you want.

> - maybe get rid of some of the many for loops and i18n calls there by
> holding the translated encoding entries inside an static
> QStringList...

Make it so.

Regards,
Ingo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8NPaeGnR+RTDgudgRAjHUAJ0UVCGZzGZBUfEhI2dCoKrFnxre5QCfYmNj
ogPCCS2gLm6ISf8mixdjOSQ=
=jRhJ
-----END PGP SIGNATURE-----
_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]