[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: KMMsgDict slowness
From:       Ronen Tzur <rtzur () shani ! net>
Date:       2002-01-02 13:54:03
[Download RAW message or body]

Hello

On Tuesday 01 January 2002 14:10, Michael Häckel wrote:
> On Wednesday 02 January 2002 01:31, Ronen Tzur wrote:
> > I tried that, most of the time I interrupted it was in Dw*-related
> > functions. Never in KMMsgList or KMMsgDict functions.
> >
> > Please try the patch, say if it makes any difference for you.
>
> The result is 15 moved mails per second. This is much better (ten minutes
> for moving 10000 mails) but still not really fast.

Ten hours to ten minutes, that is really great improvement, even
if still not enough.   I'm glad it turned out this way.

> Seems we should adjust the prime number according to the number of total
> mails the user is storing though. Maybe we could remember how many mails
> the user had the last time and the use one of a few hardcoded prime numbers
> the next time.

If that's ok, I'd like to first try and reduce the number of lookups,
before trying to degrade the hashtable into a mere array.  :-)

In this new patch that I'm attaching, the r-dict is no longer on a hash table,
but is accessible using "KMMsgDictREntry *folder->rDict()."

I've tested this a little and it seems it works:  messages still keep their
correct serial number even when moving folders, and even when KMail
is shut down and restarted after the message has moved.

For me it shaved off a few seconds when moving those 9000 messages.
That is, with this patch it takes exactly 120 seconds.

Please try it.

["theDiff2.gz" (application/x-gzip)]
_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]