[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] fixes for new ConfigureDialog: PGP tab layout, transports problem
From:       Marc Mutz <Marc.Mutz () uni-bielefeld ! de>
Date:       2001-11-30 16:12:10
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 30 November 2001 16:11, Michael Häckel wrote:
<snip>
> I currently can't get your patch compiled, sorry. Anyway, I think, I
> better wait, until you are finished.

There are no more known problems (but I haven't tested all aspects of 
the dialog thoroughly yet). 

<snip>
> configuredialog.moc:341: `slotChangeDefaultPGPKey' undeclared (first
> use this function)
> configuredialog.moc:342: `slotSignatureEdit' undeclared (first use
> this function)
> configuredialog.moc:343: `slotEnableSignatureEditButton' undeclared
> (first use this function)
<snip>

This looks as though your .moc file wasn't recreated. It works here.
Try removing the moc files.

>  - Appearance->Layout->Threading options is now disabled when
>    "Thread list of message headers" is not checked.
>    Both group boxes on that tab use QButtonGroup to keep track of
>    the radio's and uses setButton to init and id(selected()) to read
>    the settings.
>
> This is not good, because that is only the default value, that is
> configured there.

I see. Changed.

>  - maildir is now default. <- OK??
>
> Let's simply try it, but it should be also default for inbox, etc.

Fixed.

>  - am I right in that the connect( SIGNAL(closeClicked()), ...) in
>    ConfigureDialog's c'tor is superfluous, too? That signal is only
>    emitted when a "Close" button is present, which isn't the case,
> no?
>
> Isn't that the "X" button in the caption?

from the doc of KDialogBase: void  closeEvent ( QCloseEvent *e ) 
Q> Detects when a dialog is being closed from the window manager 
Q> controls. If the Cancel or Close button is present then the button is 
Q> activated. Otherwise standard QDialog behavior will take place. 

> TODO:
>  - write a profile manager
>  - go through the dialog and fix duplicate keybindings
>  - expand ListView to take over the common tasks of 'Up' and 'Down',
>    'remove' etc. and to provide in-place renaming where it makes
> sense.
>  - make pages only after the user clicked on the icon
>  - or (less ambitious): setup tabs and pages only after the user
> clicked on it.
>
> I'm not fully convinced, that now is the time for major rewrites that
> don't give any advantage to the user. I though, you did only want to
> split up configuredialog.cpp into two smaller files.

I wanted to red rid of implementation details in configuredialog.h and 
give each page it's own class. That it effectively became a rewrite is 
due to the fact that each and every member variable changed it's name, 
so I went through the code and fixed some ugliness down the line.
There's not much functional code changes, it still is a major 
code-shove-around.

> Besides that,
> the aegypten team will then have an even more hard job with merging.

I think they will have a way easier job with the new design, since they 
can implement their stuff in the PluginPage.

> Nevertheless, then do it, but please try do get it ready for the
> beta.
<snip>

The thing that prevents this patch from being applied right now is
1. lack of testing
2. lack of profile manager.

- - I will tackle the profile manager today and tomorrow.
- - If someone else could fix the keybindings, that would be nice (note: 
it wasn't me who messed them up :-)
- - the listview and delayed construct stuff doesn't need to go in anytime 
soon.
- - the delayed setup stuff should be as easy as calling setup() from 
individual showEvent reimplementations.

Marc

- -- 
Ich gegen meinen Bruder.
Ich und mein Bruder gegen unseren Cousin.
Ich, mein Bruder und unser Cousin gegen unsere Nachbarn.
Wir alle gegen den Fremden.
                                      -- Beduinen-Sprichwort
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8B8zO3oWD+L2/6DgRAsXKAKDzc8HIj2CrMpXbD7jowf6vG05+XQCgyPES
3x+fBbejSBiLS4LWd6vE8MY=
=lzqx
-----END PGP SIGNATURE-----

_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]