[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [PATCH] Configuredialog (was: Re: [PATCH]: SLightly change a few strings)
From:       Marc Mutz <mutz () kde ! org>
Date:       2001-11-30 10:51:10
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 30 November 2001 00:22, Ingo Klöcker wrote:
<snip>
> Marc? Can I commit my patch this weekend? It should really be
> commited before the beta1 packages are made.
<snip>

Sorry that it took so long, but it turned out to almost be a rewrite 
(ie. I don't think there's a line of code that's untouched, which 
should have been quite clear to me in the first place, since all member 
variables have lost their mXyZ. prefix).

I'm currently testing these changes. This is the current status:

- - - Profiles don't work. I want to write a small profilemanager, since now 
that every page and tab is a class of it's own, the old way to simply 
write out the data into the widgets is ugly.
- - - There are still bugs in setup() and apply() functions (e.g. writing 
entries to the wrong group of trying to read from the wrong group), 
though I currently _know_ only of a problem with the network page.

BIG WARNING: This patch is the result of a fortnight of hacking without 
intermediate testing cycles! Backup your .kde/share/config/kmailrc 
before playing with this (known to be buggy) patch. Consider this a 
"technology preview" and help squash bugs if you want, but don't blame 
me if it starts eating your pets. You have been warned.

The changes in detail (most of them, anyway):

- - - Adds QT_NO_COMPAT to KDE_CXXFLAGS again :-)
- - - Contains the last posted patch re: Misc page.
- - - ConfigureDialog only exposes it's user-interface.
  o private classes are encapsulated in configuredialog_p
- - - There's a new SimpleStringListEditor (listbox + array of buttons),
  used in the subject and charset tabs of the composer page.
- - - LanguageItems are now value-based.
- - - each page is now a widget of it's own.
  o slots have been moved to the corresponding widget.
- - - Network->Receiving->New Mail Notification->Exec. command
  now has a KURLRequester instead of lineedit+button
- - - dto. for external editor on Composer->General
  // tries to filter for executables, but that only turns up .desktop 
files...
- - - Appearance->Layout->Threading options is now disabled when
  "Thread list of message headers" is not checked.
  Both group boxes on that tab use QButtonGroup to keep track of
  the radio's and uses setButton to init and id(selected()) to read
  the settings.
- - - The code for scoring was removed where it would have needed porting.
  (ie. everywhere :-( ) One can always check out older versions of 
  configuredialog.cpp to get it back...
- - - Clicking "Help" now goes to the current page's help, not the one of
  the whole dislog
  o the anchors have been partly renamed to be consistent. They all
    follow the scheme "configure-<page>" for pages, and
    "configure-<page>-<tab> for individual tabs.
- - - maildir is now default. <- OK??
- - - fixes spelling of QuotedText[123] config keys (needs entry in 
kconf_update!)

- - - If I comment out the setCurrentItem line of 
  SimpleStringListEditor::slotUp(), is it a Qt bug I see (the dead item 
  that results from the execution)??
- - - am I right in that the clearing of mModifiedAccounts,
  mAccountsToDelete and mNewAccounts in slotOk is superfluous? After
  all, they have already been cleared in apply()..., no?
- - - am I right in that the connect( SIGNAL(closeClicked()), ...) in
  ConfigureDialog's c'tor is superfluous, too? That signal is only
  emitted when a "Close" button is present, which isn't the case, no?

TODO:
- - - write a profile manager
- - - go through the dialog and fix duplicate keybindings
- - - expand ListView to take over the common tasks of 'Up' and 'Down', 
  'remove' etc. and to provide in-place renaming where it makes sense.
- - - make pages only after the user clicked on the icon
- - - or (less ambitious): setup tabs and pages only after the user clicked
  on it.

Marc

- -- 
The road is still long. Thank you everybody. Thanks to all who make an
effort on behalf of democracy in China. They have come. Goodbye.
              -- last EMail of Huang Qi, webmaster of 6-4tianwang.com,
                 sentenced in China for posting Party-critical texts.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8B4Hr3oWD+L2/6DgRAtncAKCdAjh5yBl2j0m8PJoVExw3+O/4bgCg33Fx
jizxo1mBTBs3QzVdoba6J+8=
=Di1I
-----END PGP SIGNATURE-----

["configuredialog-big-patch.diff.bz2" (application/x-bzip2)]
_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]