[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: (Short) stupid question about the KMail sources
From:       Ronen Tzur <rtzur () shani ! net>
Date:       2001-11-27 21:42:21
[Download RAW message or body]

Hi

On Tuesday 27 November 2001 23:34, Michael Häckel wrote:
> On Tuesday 27 November 2001 22:07, Magnus von Koeller wrote:
> > <snip>
> > int KMFolder::find(unsigned long msgSerNum) const
> > {
> >   for (int i=0; i<mMsgList.high(); ++i)
> >     if (mMsgList[i]->getMsgSerNum() == msgSerNum)
> >       return i;
> >
> >   return -1;
> > }
> > </snip>
> >
> > Am I right to assume that this function goes through all messages in
> > a folder and then returns the index of a matching message? Is an int
> > big enough if you want to go through 100000 messages?
>
> Seems it didn't look at a recent patch well enough. Actually I hope, that
> this function is obsolete now and not used at all.
> All serial numbers are stored in a QDict which allows very fast lookups.

Yep, I think it can be safely removed.  Should I include this removal
in this clean up patch I keep talking about?  ;)


tzuk
_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]