[prev in list] [next in list] [prev in thread] [next in thread] 

List:       klee-commits
Subject:    [klee-commits] [klee/klee] a01f46: Compare LLVM_VERSION_SHORT to "140" rather than "14".
From:       Michael <noreply () github ! com>
Date:       2024-02-28 10:11:35
Message-ID: klee/klee/push/refs/heads/master/399ea4-a01f46 () github ! com
[Download RAW message or body]


*******************
This email originates from outside Imperial. Do not click on links and attachments \
unless you recognise the sender.  If you trust the sender, add them to your safe \
senders list https://spam.ic.ac.uk/SpamConsole/Senders.aspx to disable email stamping \
                for this address.
*******************
  Branch: refs/heads/master
  Home:   https://github.com/klee/klee
  Commit: a01f46c09137d521e736042bfb0395321f21e0fc
      https://github.com/klee/klee/commit/a01f46c09137d521e736042bfb0395321f21e0fc
  Author: Michael Herstine <sp1ff@pobox.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M scripts/build/p-libcxx.inc
    M scripts/build/p-llvm.inc

  Log Message:
  -----------
  Compare LLVM_VERSION_SHORT to "140" rather than "14".

In commit 2b07721, support was added to p-libcxx.inc & p-llvm.inc
for LLVM versions 14+ (in which, apparently, certain build flags
were changed). To detect these recent versions, the variable
LLVM_VERSION_SHORT was compared numerically to "14"-- the intent
obviously being to express "LLVM version 14 or later".

However, in both v-clang.inc & v-llvm.inc, LLVM_VERSION_SHORT
is defined as the concatenation of LLVM_VERSION_MAJOR and
LLVM_VERSION_MINOR. Therefore, on a machine with, say, LLVM
13.0 installed, LLVM_VERSION_SHORT will be "130" which compares
as larger than "14".

This patch changes the comparison to be against "140".



To unsubscribe from these emails, change your notification settings at \
https://github.com/klee/klee/settings/notifications

_______________________________________________
klee-commits mailing list
klee-commits@imperial.ac.uk
https://mailman.ic.ac.uk/mailman/listinfo/klee-commits


[prev in list] [next in list] [prev in thread] [next in thread]