[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kjsembed
Subject:    Re: [kjsembed] eval returnvalue in
From:       Ian Reinhart Geiser <geiseri () yahoo ! com>
Date:       2006-10-06 0:40:55
Message-ID: 200610052041.02861.geiseri () yahoo ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


First thanks for the patch.  Its close, but not quite.  With some minor 
modifications it can handle anything handled by the metatype system. (Basicly 
you do not create the variant until the end, but only if the metatype is 
handled as a QVariant.  Now this gets "funny" because anything that has a 
metatype in theory can be handled as a variant.  So because of this we need 
to check if the usertype is in fact covered by the range of QVariant.  At 
that point we know its  a QVariant and we deal with it as such.  If it is not 
a variant type then we need to play some further games with the meta objects 
and see if we can QObject cast it.  This is were I am wandering in the 
wilderness now.  Because of some other personal problems that have taken 
priority this week I have not had enough time to finish this)

The patch is good though, and it may be an adequate stopgap measure until the 
full solution is in place.   Matt, Erik thoughts?

Cheers
	-ian reinhart geiser

On Thursday 05 October 2006 19:35, Sebastian Sauer wrote:
> hi * :)
>
> the attached patch tries to add support for handling of slot returnvalues
> at the QObject binding.
>
> * Unittest I used to test the returnvalues (bytearray does not work, how to
> define a QStringList in javascript?);
> http://websvn.kde.org/trunk/koffice/libs/kross/test/unittest.js?rev=586618&
>view=markup
>
> * I didn't regressiontest it so much.
>
> * It may crash or do some other dirty things if e.g. a QVariant::UserType
> got passed.
>
> * Any feedback is welcome :)

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kjsembed mailing list
kjsembed@kde.org
https://mail.kde.org/mailman/listinfo/kjsembed


[prev in list] [next in list] [prev in thread] [next in thread]