[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kgraphviewer-devel
Subject:    Re: [kgraphviewer-devel] Port to KF5
From:       Milian Wolff <mail () milianw ! de>
Date:       2016-05-02 20:45:31
Message-ID: 1498989.7MBKmJFQ0N () agathebauer
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Montag, 2. Mai 2016 00:16:31 CEST kleag@free.fr wrote:
> Hello,
> 
> I tried to compile the frameworks branch but it failed. Then I changed some
> things by tries and failures and got it to compile and work with the
> attached patch.
> 
> Well, I'm not sure it's OK because I did not find a lot of documentation
> about the changes in the cmake commands for parts and not a lot of
> examples.
> 
> What do you think ?

Looks OK to me, I assume you have checked other applications to find the CMake 
variables you are using now? That would have been what I'd do.

If in doubt, write to kde-buildsystem@kde.org with a question to review this 
patch.

Thanks

-- 
Milian Wolff
mail@milianw.de
http://milianw.de
["signature.asc" (application/pgp-signature)]
[Attachment #6 (text/plain)]

_______________________________________________
kgraphviewer-devel mailing list
kgraphviewer-devel@kde.org
https://mail.kde.org/mailman/listinfo/kgraphviewer-devel


[prev in list] [next in list] [prev in thread] [next in thread]