'Re: [kgraphviewer-devel] Review Request: Fix the missing icons in the setting dialog of kgrapheditor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kgraphviewer-devel
Subject:    Re: [kgraphviewer-devel] Review Request: Fix the missing icons in the setting dialog of kgrapheditor
From:       "Commit Hook" <null () kde ! org>
Date:       2012-07-09 14:27:55
Message-ID: 20120709142755.1802.6304 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105482/#review15571
-----------------------------------------------------------

This review has been submitted with commit c1e4d0d7f67f6154ab4a95c6a052f41d=
43a5ac9d by Jekyll Wu to branch master.

- Commit Hook

On July 8, 2012, 6:42 p.m., Jekyll Wu wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105482/
> -----------------------------------------------------------
> =

> (Updated July 8, 2012, 6:42 p.m.)
> =

> =

> Review request for KGraphViewer.
> =

> =

> Description
> -------
> =

> I'm just looking at http://techbase.kde.org/Projects/Oxygen/KDE4_Missing_=
Icons, and I notice that the problem of missing icons is "fixed" in kgraphv=
iewer but not in kgrapheditor. So this patch just repeats the work done in =
commit  7a72a3eaf649508dbcd60b86ecd9f6b7325bfce5.
> =

> I'm not sure commit 7a72a3eaf649508dbcd60b86ecd9f6b7325bfce5 is the right=
 fix, but I think consistency is important.
> =

> =

> Diffs
> -----
> =

>   src/kgrapheditorConfigDialog.cpp 7b7ad15 =

> =

> Diff: http://git.reviewboard.kde.org/r/105482/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Jekyll Wu
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105482/">http://git.reviewboard.kde.org/r/105482/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c1e4d0d7f67f6154ab4a95c6a052f41d43a5ac9d by Jekyll Wu to branch \
master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 8th, 2012, 6:42 p.m., Jekyll Wu wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KGraphViewer.</div>
<div>By Jekyll Wu.</div>

<p style="color: grey;"><i>Updated July 8, 2012, 6:42 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m just looking at \
http://techbase.kde.org/Projects/Oxygen/KDE4_Missing_Icons, and I notice that the \
problem of missing icons is &quot;fixed&quot; in kgraphviewer but not in \
kgrapheditor. So this patch just repeats the work done in commit  \
7a72a3eaf649508dbcd60b86ecd9f6b7325bfce5.

I&#39;m not sure commit 7a72a3eaf649508dbcd60b86ecd9f6b7325bfce5 is the right fix, \
but I think consistency is important. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kgrapheditorConfigDialog.cpp <span style="color: grey">(7b7ad15)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105482/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kgraphviewer-devel mailing list
kgraphviewer-devel@kde.org
https://mail.kde.org/mailman/listinfo/kgraphviewer-devel

[prev in list] [next in list] [prev in thread] [next in thread] 