[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] Bug #28908: login not possible (cookies ?)
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-08-26 9:56:18
[Download RAW message or body]

On Saturday 25 August 2001 19:16, Martin Antenreiter wrote:
> On Sat, 25 Aug 2001, David Faure wrote:
> 
> > I can't comment on whether it's correct or not, not knowing the code, but
> > I can nitpick the patch :)
> > '.' + ... is dangerous, I'm even surprised it compiles.
> 
> Thank you for the hint, but I don't see why it is dangerous. There exist
> a method QString operator+ (char c, const QString & s)...

Now this is interesting... You caught me, I didn't know that.
I guess I'm confusing with "a" + 'b', "a" + QString, and many other
combinations that aren't allowed :)

> > Better use lastCookie.mDomain.prepend( '.' );
> 
> Okay! I can live with this line too! :)

I think it's more efficient too ;)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/ , http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]