[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: PATCH: KonqRun::askSave and URLs containing '%'
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-08-24 18:58:47
[Download RAW message or body]

On Friday 24 August 2001 20:52, Maarten ter Huurne wrote:
> On Thursday 23 August 2001 22:21, David Faure wrote:
> > On Friday 24 August 2001 02:42, Maarten ter Huurne wrote:
> > > Hi,
> > >
> > > Below is a patch for Konqueror from KDE 2.2, which fixes a problem in
> > > KonqRun::askSave. The string displayed was created using the following
> > > code: i18n("Open '%1' using '%2'?").arg( surl ).arg(offer->name())
> > > This fails when surl contains %1 or %2 as substrings. This happens for
> > > example with URLs that contain escaped space characters (%20). The result
> > > is messages like "Open 'someXMMS0songs.m3u' using '%2'?".
> >
> > The usual fix for this is to make the "dangerous" argument the last one.
> >    i18n("Open '%2' using '%1'?").arg(offer->name()).arg( surl )
> > should work fine.
> 
> Will the translations still be valid when %1 and %2 are swapped?

No, this is obviously a change in the to-be-translated string. But in the HEAD
branch, this is no problem. The poor translators will update their translations
once more :}

> Ofcourse the swapped version still fails when the application name contains 
> %0 or %1, but that is unlikely enough to be acceptable?

I'd say so.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]