[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: PATCH: KonqRun::askSave and URLs containing '%'
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-08-23 22:21:51
[Download RAW message or body]

On Friday 24 August 2001 02:42, Maarten ter Huurne wrote:
> Hi,
> 
> Below is a patch for Konqueror from KDE 2.2, which fixes a problem in 
> KonqRun::askSave. The string displayed was created using the following code:
>   i18n("Open '%1' using '%2'?").arg( surl ).arg(offer->name())
> This fails when surl contains %1 or %2 as substrings. This happens for 
> example with URLs that contain escaped space characters (%20). The result is 
> messages like "Open 'someXMMS0songs.m3u' using '%2'?".

The usual fix for this is to make the "dangerous" argument the last one.
   i18n("Open '%2' using '%1'?").arg(offer->name()).arg( surl )
should work fine.

> 274a275,299
Please use diff -u to get context in the diffs.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]