[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    setUserStyleSheet() document-specific
From:       Dirk Mueller <mueller () kde ! org>
Date:       2001-08-22 21:59:58
[Download RAW message or body]

Hi, 

I just made setUserStyleSheet() document/KHTMLPart specific rather than 
applying it globally. IMHO this is the right move (the CSS2 spec explicitely 
mentions that the userstylesheet is to be document-specific) and it prevents 
weird crashes  - these happened because the document-specific css property 
lists in CSSStyleSelector were not recreated upon a userstylesheet change. 
and as we don't have a list of cssstyleselectors this is not too easy to 
fix. 

The disadvantage is now that the memory usage was a bit increased (the 
stylesheet is now loaded for every document and causes duplicate but 
identical properties to be generated). 

The other possible solution is testing if the userstylesheet changed 
compared to last time in styleForElement() and then recreate our caching 
information. This works as well. 

Opinions?


Dirk

[prev in list] [next in list] [prev in thread] [next in thread]