--------------Boundary-00=_8ESCERK07BXTNFUOMP2H Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit On Tuesday 31 July 2001 20:49, Martin Pley wrote: > Hi, all. > > For nearly one week the horizontal scrollbar doesn't work if you load a > large, plain image in konqueror. (nobody noticed it? :o) ) > (example: load > http://www.mathematik.uni-bielefeld.de/~mmutz/kde-developers-2400.jpg in > your konqueror and look at the hoizontal scrollbar) > The bug is there since v1.78 of /kdelibs/khtml/rendering/render_root.cpp > If you undo this commit it works again. The cvs-commit-message of 1.78 only > tells "root width fixes". So i don't know what this was for, but there were > changes only 2 lines. Anyone knows what this commit was intended for? Patch attached. Lars or Dirk, please review. The patch remembers to take in the account (possibly overflowing) inline elements when calculating the rightmost position of a document. Also removed one unnecessary call to docWidth() which is not a free method. antti --------------Boundary-00=_8ESCERK07BXTNFUOMP2H Content-Type: text/x-diff; charset="iso-8859-1"; name="rightmost_position.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="rightmost_position.patch" PyByZW5kZXJpbmcvfnJlbmRlcl9yb290LmNwcApJbmRleDogcmVuZGVyaW5nL3JlbmRlcl9mbG93 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9rZGUva2RlbGlicy9raHRtbC9yZW5kZXJp bmcvcmVuZGVyX2Zsb3cuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIxNApkaWZmIC11IC0z IC1kIC1wIC1yMS4yMTQgcmVuZGVyX2Zsb3cuY3BwCi0tLSByZW5kZXJpbmcvcmVuZGVyX2Zsb3cu Y3BwCTIwMDEvMDcvMjkgMTk6NDg6NDYJMS4yMTQKKysrIHJlbmRlcmluZy9yZW5kZXJfZmxvdy5j cHAJMjAwMS8wNy8zMSAxOTo0MjoxMgpAQCAtODEwLDE0ICs4MTAsMTIgQEAgaW50IFJlbmRlckZs b3c6OnJpZ2h0bW9zdFBvc2l0aW9uKCkgY29ucwogewogICAgIGludCByaWdodCA9IFJlbmRlckJv eDo6cmlnaHRtb3N0UG9zaXRpb24oKTsKIAotICAgIGlmICggIW1fY2hpbGRyZW5JbmxpbmUgKSB7 Ci0gICAgICAgIFJlbmRlck9iamVjdCAqYzsKLSAgICAgICAgZm9yIChjID0gZmlyc3RDaGlsZCgp OyBjOyBjID0gYy0+bmV4dFNpYmxpbmcoKSkgewotCSAgICBpZiAoIWMtPmlzUG9zaXRpb25lZCgp ICYmICFjLT5pc0Zsb2F0aW5nKCkpIHsKLQkJaW50IGNoaWxkUmlnaHQgPSB4UG9zKCkgKyBjLT5y aWdodG1vc3RQb3NpdGlvbigpOwotCQlpZiAoY2hpbGRSaWdodCA+IHJpZ2h0KQotCQkgICAgcmln aHQgPSBjaGlsZFJpZ2h0OwotCSAgICB9CisgICAgUmVuZGVyT2JqZWN0ICpjOworICAgIGZvciAo YyA9IGZpcnN0Q2hpbGQoKTsgYzsgYyA9IGMtPm5leHRTaWJsaW5nKCkpIHsKKwlpZiAoIWMtPmlz UG9zaXRpb25lZCgpICYmICFjLT5pc0Zsb2F0aW5nKCkpIHsKKwkgICAgaW50IGNoaWxkUmlnaHQg PSB4UG9zKCkgKyBjLT5yaWdodG1vc3RQb3NpdGlvbigpOworCSAgICBpZiAoY2hpbGRSaWdodCA+ IHJpZ2h0KQorCQlyaWdodCA9IGNoaWxkUmlnaHQ7CiAJfQogICAgIH0KIApJbmRleDogcmVuZGVy aW5nL3JlbmRlcl9yb290LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9rZGUva2RlbGli cy9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX3Jvb3QuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjgwCmRpZmYgLXUgLTMgLWQgLXAgLXIxLjgwIHJlbmRlcl9yb290LmNwcAotLS0gcmVuZGVyaW5n L3JlbmRlcl9yb290LmNwcAkyMDAxLzA3LzI5IDIwOjM5OjA1CTEuODAKKysrIHJlbmRlcmluZy9y ZW5kZXJfcm9vdC5jcHAJMjAwMS8wNy8zMSAxOTo0MjoxMgpAQCAtMjc0LDcgKzI3NCw3IEBAIHZv aWQgUmVuZGVyUm9vdDo6dXBkYXRlSGVpZ2h0KCkKICAgICB7CiAgICAgICAgIGlmKCBoIDwgbV92 aWV3LT52aXNpYmxlSGVpZ2h0KCkgKQogICAgICAgICAgICAgaCA9IG1fdmlldy0+dmlzaWJsZUhl aWdodCgpOwotICAgICAgICBtX3ZpZXctPnJlc2l6ZUNvbnRlbnRzKGRvY1dpZHRoKCksIGgpOwor ICAgICAgICBtX3ZpZXctPnJlc2l6ZUNvbnRlbnRzKHcsIGgpOwogICAgIH0KICAgICBtX3ZpZXct PnJlcGFpbnRDb250ZW50cyggMCwgMCwgdywgaCwgRkFMU0UgKTsgICAgICAgLy9zeW5jIHJlcGFp bnQhCiAK --------------Boundary-00=_8ESCERK07BXTNFUOMP2H--