[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH]Automatic proxy configuration
From:       Waldo Bastian <bastian () kde ! org>
Date:       2001-07-30 15:02:53
[Download RAW message or body]

On Monday 30 July 2001 05:20 am, Malte Starostik wrote:
> Am Montag, 30. Juli 2001 07:12 schrieb Waldo Bastian:
> > Hiya,
> >
> > My kfmclient crashes on the automatic proxy config stuff. The following
> > patch seems to solve it. The problem may be related to the fact that the
> > actual script causes a parse error.
>
> Feel free to send me the script :)
> I don't think that causes the crash though, I can reproduce it with a
> working script now. Patch looks good and solves the crash, I don't really
> see how it works though :(
>
> How can KProtocolManager::pac() be reentered between
> +    d->init_busy = true;
> and the former
> -        d->pac = create_pac();
> -        // Need to set d->pac here to avoid infinite recursion
> or wasn't that the problem?

The problem seems to be that d->pac->init() would call KProtocolManager (for 
the download of the script) which eventually deleted d->pac again (not sure 
why that was). With this patch init_busy is true when KPac tries to download 
the script and KProtocolManager will not try to use a proxy during this time.

> > I also notice that a job is created to "download" the script. That seems
> > unnecassery since the script is in a local file.
>
> In most cases those scripts are on a web server. Anyway, please review the
> attachted patch.

Looks good, will apply both. 

Cheers,
Waldo
-- 
Andrei Sakharov, Exiled 1980-1986, USSR, http://www.aip.org/history/sakharov/
Dmitry Sklyarov, Detained 2001-????, USA, http://www.elcomsoft.com/

[prev in list] [next in list] [prev in thread] [next in thread]