[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    PATCH: select size
From:       Daniel Naber <daniel.naber () t-online ! de>
Date:       2001-07-28 16:09:37
[Download RAW message or body]

Hi,

for me this fixes the testcase below, without the patch the list is only 
one item high instead of 5. I think the line was lost in a cleanup. Can I 
commit? 

Regards
 Daniel

<form>
<select size="5">
<option value="1">1</option>
<option value="2">2</option>
<option value="3">3</option>
</select>
</form>

-- 
Daniel Naber, Paul-Gerhardt-Str. 2, 33332 Guetersloh, Germany
Tel. 05241-59371, Mobil 0170-4819674

["select-size.diff" (text/x-diff)]

Index: render_form.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/rendering/render_form.cpp,v
retrieving revision 1.127
diff -u -r1.127 render_form.cpp
--- render_form.cpp	2001/07/28 14:17:27	1.127
+++ render_form.cpp	2001/07/28 15:53:58
@@ -929,6 +929,7 @@
         if(size < 1)
             size = QMIN(static_cast<KListBox*>(m_widget)->count(), 10);
 
+        height = size*height + 2*w->frameWidth();
         setIntrinsicWidth( width );
         setIntrinsicHeight( height );
     }


[prev in list] [next in list] [prev in thread] [next in thread]