[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    [PATCH] Allows 'px' in non-CSS widths
From:       Kurt Granroth <granroth () suse ! com>
Date:       2001-06-12 18:00:46
[Download RAW message or body]

This patch will allow for the 'px' suffix to be used in non-CSS
situations.  For instance, WIDTH="690px" is identical to WIDTH="690"

Now this isn't part of the HTML or XHTML spec and 'px' is technically
only supposed to be used with CSS... *however* it might be a good idea
for us to handle it for the following reasons:

1) I've seen a few sites that use them.  These sites are very broken
   in KHTML without the patch (www.soulmachine.com is an example)
2) As CSS becomes more and more popular, more people will start using
   'px' in non-CSS as it is somewhat habit forming
3) Mozilla and IE both support it
-- 
Kurt Granroth            | http://www.granroth.org
KDE Developer/Evangelist | SuSE Labs Open Source Developer
granroth@kde.org         | granroth@suse.com
            KDE -- Conquer Your Desktop

["dom_stringimpl.diff" (text/plain)]

Index: dom_stringimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/xml/dom_stringimpl.cpp,v
retrieving revision 1.37
diff -b -u -u -r1.37 dom_stringimpl.cpp
--- dom_stringimpl.cpp	2001/04/05 22:53:23	1.37
+++ dom_stringimpl.cpp	2001/06/12 17:29:52
@@ -302,7 +302,9 @@
              *ch != '.' &&
              *ch != '%' &&
              *ch != ' ' &&
-             *ch != '*' )
+             *ch != '*' &&
+             *ch != 'p' &&
+             *ch != 'x' )
             return ch - s;
     }
 


[prev in list] [next in list] [prev in thread] [next in thread]