[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: change to konq frame header. (PATCH)
From:       Mark Deneen <deneen () bucknell ! edu>
Date:       2001-05-11 10:25:16
[Download RAW message or body]

ok, sorry.  I am really dumb.  :-)

I sent the same patch!

Attached is the real one.

:-)

On Friday 11 May 2001 6:11, you wrote:
> On Friday 11 May 2001 02:50, Mark Deneen wrote:
> > The patch that was applied to cvs had a bug in it.  I did not know that
> > the slot which I had put the code in did not get called when konqueror
> > loaded a profile.
> >
> > This patch fixes that.
>
> Hmm, that patch includes everything, so it's hard to apply the fix.
> Can you update from CVS and run cvs diff, to get an incremental diff
> (i.e. only the fix) - or describe the fix ?
>
> I can provide a CVS account, too, if you want to do more development
> on Konqueror - which would be much appreciated !!

["konq.patch" (text/x-c++)]

Index: konq_guiclients.cc
===================================================================
RCS file: /home/kde/kdebase/konqueror/konq_guiclients.cc,v
retrieving revision 1.36
diff -u -3 -p -r1.36 konq_guiclients.cc
--- konq_guiclients.cc	2001/05/10 16:20:24	1.36
+++ konq_guiclients.cc	2001/05/11 00:46:49
@@ -249,11 +249,6 @@ void ToggleViewGUIClient::slotToggleView
 
     m_mainWindow->viewCountChanged();
 
-    // turn on frame header if it is vertical.  it looked quite ugly for horizontal,
-    // but this could be fixed by having a fixed height.  (the layout stretched)
-    if( !horizontal)
-        childView->frame()->header()->setText(childView->service()->name());
-
   }
   else
   {
@@ -298,7 +293,19 @@ void ToggleViewGUIClient::slotViewAdded(
   {
     static_cast<KToggleAction *>( action )->setChecked( true );
     saveConfig( true, name );
-    view->frame()->header()->setAction(action);
+
+    // KonqView::isToggleView() is not set yet.. so just check for the orientation
+
+    QVariant vert = view->service()->property( "X-KDE-BrowserView-ToggableView-Orientation");
+    bool vertical = vert.toString().lower() == "vertical";
+
+    // if it is a vertical toggle part, turn on the header.
+    // this works even when konq loads the view from a profile.
+    if ( vertical )
+    {
+        view->frame()->header()->setText(view->service()->name());
+        view->frame()->header()->setAction(action);
+    }
   }
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]