[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Bug#24335: konqueror does not reload favorite icons
From:       Malte.Starostik () t-online ! de (Malte Starostik)
Date:       2001-04-19 13:55:35
[Download RAW message or body]

On Donnerstag, 19. April 2001 11:17, David Faure wrote:
> On Thursday 19 April 2001 05:40, Malte Starostik wrote:
> > On Mittwoch, 18. April 2001 23:39, David Faure wrote:
> > > On Wednesday 18 April 2001 19:59, Malte Starostik wrote:
> > > > The favicons are rechecked when you visit a page and the local copy
> > > > is older than a week now. IMHO that's enough, but of course I'm open
> > > > to other suggestions.
> > >
> > > But that's not enough to update the bookmarks ;-)
> > > I think you missed the point :)
> >
> > Maybe, thing is if you visit a page, bookmarked or not, and its favicon
> > is older than a week, it's re-downloaded. Still it might be good to check
> > favicons some time else. But when? When KDesktop starts? When Konsuqeror
> > starts? When the user opens the bookmark menu in either of them? IMHO
> > just opening the menu shouldn't trigger a download (for dialup user this
> > might be a problem).
>
> No, sure.
>
> The point at hand is: this won't update the icon in the bookmark, if it
> currently is "www" - the most common icon for bookmarks, especially before
> the favicon support.
>
> What people want - rather what I suggested to fullfil their wish :) - is
> an action "update all icons" in keditbookmarks. That means,
> checking the icon of each _bookmark_ - so this is unrelated to "visiting a
> site". What do you suggest for implementing that ? How many simultaneous
> favicon checking should we do ? Should we update _all_ icons or only those
> that are old or are not favicons ? Hmm, OTOH the user asked for an update
> so I guess we want to check _all_ the bookmarks.
> I also realise we'll surely need a qprogressdialog because this might take
> some time....
>
> Well, I don't have time now (kword) but I might enhance keditbookmarks with
> that if nobody beats me to it (doesn't look like this is going to be the
> case :(
Sorry, took a little, but I got you now :)
Just checking for /favicon.ico needs no more than a DCOP call and waiting for 
the corresponding DCOP signal. However, pages which specify a favicon via 
<link ...> are a bit more problematic. That would either require a hidden 
KHTMLPart and a connection to its setIconForURL() signal or some other 
approach to find that tag in a document. Better stay with kword for now :) 
I'll have a look at this.
-Malte

[prev in list] [next in list] [prev in thread] [next in thread]