[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Bug#20710: fix for problem #1 ?
From:       Martin Schenk <martin () schenk ! com>
Date:       2001-02-28 22:25:38
[Download RAW message or body]

I have now what looks like a fix for problem #1 (table
with 3 colums: fixed, variable, 15%)

In the file khtml/rendering/render_table.cpp, in function
RenderTable::calcColMinMax, the width of the table
is calculated. If both hasPercent and hasFixed is set,
only the minimum width of variable or relative columns
is used.

The following patch allows these columns to grow.

I hope it does not break anything else

Martin


*** /tmp/rt.old Wed Feb 28 23:22:14 2001
--- render_table.cpp    Wed Feb 28 23:21:57 2001
***************
*** 958,963 ****
--- 958,965 ----
          kdDebug( 6040 ) << "3 maxFixed=" << maxFixed << "  totalPercent=" 
<< totalPercent << endl;
          m_width = (maxFixed + minVar + minRel) * 100 /
              ourPercent;
+         // MS: allow Var and Rel columns to be bigger than minimum
+         if (minVar+minRel) m_width=QMAX(m_width, QMIN(m_maxWidth, 
availableWidth));
          m_width = QMIN (m_width, availableWidth);
      }
      else

[prev in list] [next in list] [prev in thread] [next in thread]