[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    patch: crash on my.mp3.com
From:       Simon Hausmann <simon () kde ! org>
Date:       2000-10-21 16:03:08
[Download RAW message or body]

Hi,

The attached patch fixes the crash of khtml on my.mp3.com ;-)
For some reason the value string is empty, so a simple check
does it. But I'm not sure if that's the correct way (at least
it works ;)

Thanks for checking.

Bye,
 Simon

["khtml_css_patch.txt" (text/plain)]

Index: css_valueimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/css/css_valueimpl.cpp,v
retrieving revision 1.23
diff -u -p -b -r1.23 css_valueimpl.cpp
--- css_valueimpl.cpp	2000/10/21 11:31:19	1.23
+++ css_valueimpl.cpp	2000/10/21 15:59:57
@@ -155,6 +155,10 @@ void CSSStyleDeclarationImpl::setPropert
 	m_lstValues->setAutoDelete(true);
     }
     int pos = m_lstValues->count();
+
+    if ( !value.unicode() )
+        return;
+
     parseValue(value.unicode(), value.unicode()+value.length(), id, important, m_lstValues);
 
     if(nonCSSHint) {


[prev in list] [next in list] [prev in thread] [next in thread]