[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    PATCH: Please review, Re: Bug#11990: REFRESH redirection does not work on http://store.apple.com
From:       Kurt Granroth <granroth () suse ! com>
Date:       2000-09-28 23:59:37
[Download RAW message or body]

Florent Pillet wrote:
> Package: khtml
> Version: 3.0 (KDE post 1.94 > 20000911)
> Severity: normal
> 
> Using today's CVS (2000-09-28), redirection does not work on
> http://store.apple.com. This has been failing for quite a few days.
> Here is the HTML source of the web page that fails:
> 
> <META HTTP-EQUIV=REFRESH CONTENT="1; > \
> URL=http://store.apple.com/1-800-MY-APPLE/WebObjects/AppleStore">

Okay, I have a patch for this.  But it's weird.

I tracked this down to the Decoder::decode() function!!  If it finds a
META tag outside of everything, it returns QString::null.

This perplexes me.  Why would Decoder::decode() ever return null?
Since later on, it just guesses on an encoding, shouldn't it just use
that?

Anyway, I just removed the 'return QString::null;' and it works like a
charm.

Please test!
-- 
Kurt Granroth            | http://www.granroth.org
KDE Developer/Evangelist | SuSE Labs Open Source Developer
granroth@kde.org         | granroth@suse.com
           KDE -- Putting a Friendly Face on Unix


["decoder.diff" (text/plain)]

Index: decoder.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/misc/decoder.cpp,v
retrieving revision 1.35
diff -b -u -u -r1.35 decoder.cpp
--- decoder.cpp	2000/09/27 15:57:28	1.35
+++ decoder.cpp	2000/09/28 23:51:36
@@ -191,7 +191,6 @@
                 else
                     ptr++;
             }
-            return QString::null;
         }
     }
 


[prev in list] [next in list] [prev in thread] [next in thread]