[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    default value of submit button (patch)
From:       Daniel Naber <dnaber () mini ! gt ! owl ! de>
Date:       2000-09-17 20:22:39
[Download RAW message or body]

Hi,

<input type="submit"> doesn't have a button text. This patch fixes it. Of 
course even with value="" it *will* have a text then, but that's less of a 
problem, if at all. Please apply, if okay.

Regards
 Daniel

["form-default-value.diff" (text/plain)]

Index: rendering/render_form.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/rendering/render_form.cpp,v
retrieving revision 1.53
diff -u -r1.53 render_form.cpp
--- rendering/render_form.cpp	2000/09/09 17:15:45	1.53
+++ rendering/render_form.cpp	2000/09/17 20:21:01
@@ -284,7 +284,7 @@
 
 void RenderSubmitButton::layout()
 {
-    QString value = static_cast<HTMLInputElementImpl*>(m_element)->value().isNull() ?
+    QString value = static_cast<HTMLInputElementImpl*>(m_element)->value().isEmpty() ?
         defaultLabel() : static_cast<HTMLInputElementImpl*>(m_element)->value().string();
     static_cast<PushButtonWidget*>(m_widget)->setText(value);
     static_cast<PushButtonWidget*>(m_widget)->setFont(m_style->font());


[prev in list] [next in list] [prev in thread] [next in thread]