[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: PATCH: Minor Cookiejar corrections
From:       Waldo Bastian <bastian () kde ! org>
Date:       2000-09-05 1:19:14
[Download RAW message or body]

On Wed, 30 Aug 2000, Dawit Alemayehu wrote:

> > Hi (Waldo),
>
> Patch below to address a two minor and one important issue:
>
> - Changed if (strncasecmp(cookieStr, "Set-Cookie: ", 12) == 0)  to
>    if (strncasecmp(cookieStr, "Set-Cookie:", 11) == 0) to be a bit more
>    tolerant to brain dead servers :))

Added.

> - Remove the check for "Set-Cookie2".  What is that ????  IMHO it is really
>    taking unecessary space and should be removed.

Some sites use it. Kept it in.

> - Fix ::extractDomain to handle same URLs like "linuxtoday.com" &
>    "www.linuxtoday.com" correctly.  Right now a ::findCookie(...) would
>    fail for either if the other set the cookie...

Added.

Cheers,
Waldo
-- 
KDE/Linux, Leading the Desktop Revolution.

[prev in list] [next in list] [prev in thread] [next in thread]